Review Request 124906: Load plugins even if device is not paired but reachable

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124906/#review84315
-----------------------------------------------------------



src/org/kde/kdeconnect/Device.java (line 558)
<https://git.reviewboard.kde.org/r/124906/#comment58383>

    If (listens to unpaired)



src/org/kde/kdeconnect/Plugins/PluginFactory.java (line 148)
<https://git.reviewboard.kde.org/r/124906/#comment58382>

    Can't this be part of plugininfo, instead of trading it through reflection? :/


- Albert Vaca Cintora


On Aug. 24, 2015, 11:01 p.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124906/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2015, 11:01 p.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Plugins should be loaded even if device is not paired, otherwise they won't be able to listen to NetworkPackages from the unpaired devices.
> 
> 
> Diffs
> -----
> 
>   src/org/kde/kdeconnect/Device.java 09c7549 
>   src/org/kde/kdeconnect/Plugins/Plugin.java eff176f 
>   src/org/kde/kdeconnect/Plugins/PluginFactory.java e063d85 
> 
> Diff: https://git.reviewboard.kde.org/r/124906/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150825/cedbbd21/attachment.html>