Review Request 124312: Initial SSL implementation

[Aleix Pol Gonzalez]

> On Aug. 13, 2015, 4:31 p.m., Aleix Pol Gonzalez wrote:
> > I still haven't been able to use the SSL branch both on kde and android. I'm getting these warnings nowadays: https://paste.kde.org/pdvyn7szu
> > 
> > Both devices detect each other, but for some reason the pairing doesn't work.
> > 
> > It probably should be fixed, or at least we need more debug information, to know what's going on.
> 
> Vineet Garg wrote:
>     Since on kde side we have LanDeviceLink and on Android we have LanLink, I used these names as it is, which may be the reason for that behaviour. Fixed that issue now, there should be successful pairing now. Get latest android apk from here https://drive.google.com/folderview?id=0B7UrqqDErPX4fkxfSXVTb3FybmVxcmJ2YkJRQVkwQVUwNGFLWkZqSnBETVZSUzdrVWhwNWs&usp=sharing
> 
> Aleix Pol Gonzalez wrote:
>     I updated the APK, I could request the pairing, but then it didn't work, probably because of the `SSL Error : "The certificate is not yet valid"`?
>     https://paste.kde.org/pro3nvcr9
> 
> Vineet Garg wrote:
>     You have time difference between your devices ? Normal servers tends to update their certificate time to time to avoid risk of compromisation of private key. I think we don't need such time bound here. I will remove this error from list.

No, they both use the same timezone. I'll try with your changes nevertheless...


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124312/#review83769
-----------------------------------------------------------


On Aug. 12, 2015, 8:27 p.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124312/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2015, 8:27 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> * Similar to Android version, this SSL implementation supports old version also.
> * Certificate is generated when public key is generated using QCA, but used as QSslCertificate because QSslSocket don't like QCA certificate.
> * A new server is written overriding QTcpServer for setting socket descriptor to QSslSocket.
> * QSslSocket works as plain socket to transfer identity package and then either uses encrypted mode or normal mode according to the received package.
> * If connetion is to be on SSL, new link is only added after successful handshake.
> * Certificate is embedded into identity package on start of encrypted mode and then set in device using it.
> * PairingHandler is added like in Android version so that each LinkProvider manage pairing according to its own rules.
> 
> P.S. : Uploaded the patch with some debug statements, will comment out them.
> 
> 
> Diffs
> -----
> 
>   cli/kdeconnect-cli.cpp 536c754 
>   core/CMakeLists.txt dd8fedb 
>   core/backends/devicelink.h 0ae6c00 
>   core/backends/lan/CMakeLists.txt 7c5be38 
>   core/backends/lan/downloadjob.h eeeab07 
>   core/backends/lan/downloadjob.cpp bba2e98 
>   core/backends/lan/landevicelink.h 7d31881 
>   core/backends/lan/landevicelink.cpp 0987057 
>   core/backends/lan/lanlinkprovider.h b379434 
>   core/backends/lan/lanlinkprovider.cpp f5d2b22 
>   core/backends/lan/lanpairinghandler.h PRE-CREATION 
>   core/backends/lan/lanpairinghandler.cpp PRE-CREATION 
>   core/backends/lan/server.h PRE-CREATION 
>   core/backends/lan/server.cpp PRE-CREATION 
>   core/backends/lan/socketlinereader.h b3be55a 
>   core/backends/lan/socketlinereader.cpp a6bd85e 
>   core/backends/lan/uploadjob.h 12b6f7e 
>   core/backends/lan/uploadjob.cpp b0d35fc 
>   core/backends/linkprovider.h f4fc309 
>   core/backends/loopback/loopbackdevicelink.h 9d1ae14 
>   core/backends/loopback/loopbackdevicelink.cpp 718c5b8 
>   core/backends/pairinghandler.h PRE-CREATION 
>   core/backends/pairinghandler.cpp PRE-CREATION 
>   core/daemon.h 674ca01 
>   core/daemon.cpp af4c67b 
>   core/device.h 03f528c 
>   core/device.cpp c2dc609 
>   core/kdeconnectconfig.h af6c6df 
>   core/kdeconnectconfig.cpp 919505c 
>   core/networkpackage.h 6a0bf9c 
>   core/networkpackage.cpp 64cfab7 
>   plugins/sftp/mounter.h 76ac860 
>   tests/CMakeLists.txt b00a574 
>   tests/kdeconnectconfigtest.cpp PRE-CREATION 
>   tests/lanlinkprovidertest.cpp PRE-CREATION 
>   tests/testsocketlinereader.cpp 77a9b4b 
>   tests/testsslsocketlinereader.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124312/diff/
> 
> 
> Testing
> -------
> 
> * Working fine, tested using connection to Android devices.
> * Pairing handler needs to be tested using two LinkProvider, working fine with one, but there be some problems with two LinkProviders simultaneouly.
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150817/1da5c000/attachment.html>