Review Request 124551: One Time Share - Enables to share files android to android without pairing devices

[Albert Vaca Cintora]

> On ago. 13, 2015, 10:22 p.m., Ashish Bansal wrote:
> > src/org/kde/kdeconnect/Device.java, line 480
> > <https://git.reviewboard.kde.org/r/124551/diff/1/?file=388842#file388842line480>
> >
> >     First of all sorry, I forgot to pull the latest changes and so this doesn't apply on latest master. I can fix this up.
> >     
> >     I wrote it some months back. Now I was checking this and I myself didn't like this approach, hardcoding the plugin name. Can someone please suggest be better design/approach for this?

Plugin could be able to register themselves in the Device class to receive unencrypted packages, something like this:

device.registerUnpairedPackageListener(callback);

If the device receives an unencrypted package and its not a pairing package, it will call the callbacks for the plugins that registered for unencrypted packages to see if anyone can handle it.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124551/#review83795
-----------------------------------------------------------


On jul. 31, 2015, 6:58 a.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124551/
> -----------------------------------------------------------
> 
> (Updated jul. 31, 2015, 6:58 a.m.)
> 
> 
> Review request for kdeconnect, Àlex Fiestas, Albert Vaca Cintora, and Aleix Pol Gonzalez.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Select file and click Share via KDE Connect and it will show you two sections, Share to Reachable and Share to Paired. Choose Share to Reachable and it'll show the notification to Accept/Reject file.
> 
> 
> Diffs
> -----
> 
>   AndroidManifest.xml 556b06b 
>   res/layout/activity_main.xml 996dc57 
>   res/layout/activity_one_time_receive.xml PRE-CREATION 
>   res/values/strings.xml 6984ce6 
>   src/org/kde/kdeconnect/Device.java 9fe583c 
>   src/org/kde/kdeconnect/NetworkPackage.java e5a777e 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/OneTimeReceiveActivity.java PRE-CREATION 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/ShareActivity.java f409fda 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java 26c2773 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/TransferFile.java PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124551/diff/
> 
> 
> Testing
> -------
> 
> Compiles fine. I had tested it earlier and I think it was working fine at that time but still I would say "it needs testing". It would be great if someone else could do that. Otherwise I'll test it soon in some days.
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150816/05430d90/attachment.html>