Review Request 123325: Drop dependency of KIO from kdeconnectcore

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123325/#review79233
-----------------------------------------------------------


I think it's worth changing KIO so it doesn't need the entire file to be loaded in memory, but we can merge this anyway and do it afterwards.


core/filetransferjob.cpp (line 47)
<https://git.reviewboard.kde.org/r/123325/#comment54135>

    if (size > -1)



core/filetransferjob.cpp (line 107)
<https://git.reviewboard.kde.org/r/123325/#comment54134>

    Don't remove the check for mSize > -1, sometimes (when we don't know it) it can be -1. (Also, you removed it from here but not from the next if block.



daemon/kdeconnectd.cpp (line 97)
<https://git.reviewboard.kde.org/r/123325/#comment54133>

    Remove this comment and, instead, add a default implementation of this function that uses QNetworkAccessManager if the developer doesn't override it.


- Albert Vaca Cintora


On abr. 19, 2015, 6:45 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123325/
> -----------------------------------------------------------
> 
> (Updated abr. 19, 2015, 6:45 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Use QNetworkAccessManager for storing the files we receive instead of directly KIO, then provide the KIO-based QNetworkAccessManager from the daemon. This way we'll still get the KIO network-transparency, but the library only depenends on QtNetwork, which will be easier to get in some platforms.
> 
> After this change, we only depend on KConfig, KI18n and KCoreAddons, which are tier1 and really easy to work with on any platform.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt dbaa039 
>   core/CMakeLists.txt f465959 
>   core/daemon.h 654441f 
>   core/filetransferjob.h 973bd3a 
>   core/filetransferjob.cpp 27ed8e8 
>   daemon/CMakeLists.txt 852e779 
>   daemon/kdeconnectd.cpp 25632fd 
> 
> Diff: https://git.reviewboard.kde.org/r/123325/diff/
> 
> 
> Testing
> -------
> 
> None, don't give a ship it. I only worked on it on the airplane, so I couldn't test it. If somebody wants to help with the testing, I'll welcome it.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150420/2bd298dc/attachment.html>