Review Request 123325: Drop dependency of KIO from kdeconnectcore

[Aleix Pol Gonzalez]

> On April 14, 2015, 5:19 a.m., Albert Vaca Cintora wrote:
> > Why is the KIO NetworkAccessManager not working? :( And why do we need to store in memory? Is there any way we can fix this?
> 
> Aleix Pol Gonzalez wrote:
>     I don't know why it isn't working, I'll have to investigate.
>     
>     We probably don't need to. I tried just forwarding the data, but ::put would stop reading as soon as it arrived to the end of the buffer, without waiting for further data to come in. I'll investigate here as well.

Reason is how accessmanager.cpp is implemented. First thing it does is ::readAll().
See line 255:
http://quickgit.kde.org/?p=kio.git&a=blob&h=239281e21f9a4f8e80e72fcba22496f4b5a95af8&hb=2104ca85a8949b76565ecd80afa8ea7c05674aa1&f=src%2Fwidgets%2Faccessmanager.cpp

It can probably be fixed, I don't really know how yet.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123325/#review78913
-----------------------------------------------------------


On April 14, 2015, 4:42 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123325/
> -----------------------------------------------------------
> 
> (Updated April 14, 2015, 4:42 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Use QNetworkAccessManager for storing the files we receive instead of directly KIO, then provide the KIO-based QNetworkAccessManager from the daemon. This way we'll still get the KIO network-transparency, but the library only depenends on QtNetwork, which will be easier to get in some platforms.
> 
> After this change, we only depend on KConfig, KI18n and KCoreAddons, which are tier1 and really easy to work with on any platform.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt dbaa039 
>   core/CMakeLists.txt f465959 
>   core/daemon.h 654441f 
>   core/filetransferjob.h 973bd3a 
>   core/filetransferjob.cpp 27ed8e8 
>   daemon/CMakeLists.txt 852e779 
>   daemon/kdeconnectd.cpp 25632fd 
> 
> Diff: https://git.reviewboard.kde.org/r/123325/diff/
> 
> 
> Testing
> -------
> 
> None, don't give a ship it. I only worked on it on the airplane, so I couldn't test it. If somebody wants to help with the testing, I'll welcome it.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150420/83f7be6a/attachment-0001.html>