Review Request 123263: WIP: KDE Connect backend for Solid

[Lamarque Souza]

> On April 5, 2015, 5:54 p.m., Lamarque Souza wrote:
> > src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp, line 79
> > <https://git.reviewboard.kde.org/r/123263/diff/1/?file=360131#file360131line79>
> >
> >     Is it possible to retrieve a correct value for this and the other values below (timeToEmpty, timeToFull, etc)?
> 
> Kai Uwe Broulik wrote:
>     I suppose, but that needs implementing on the KDE Connect side
> 
> Albert Vaca Cintora wrote:
>     From Android we could expose any of these: http://developer.android.com/reference/android/os/BatteryManager.html
>     
>     Which ones would be useful in solid?

According to /usr/include/solid/battery.h the ones we really need are: for isPlugged we need BATTERY_PLUGGED_AC, BATTERY_PLUGGED_USB and BATTERY_PLUGGED_WIRELESS. isPowerSupply: I think it is always false in this case. type: always PhoneBattery. chargePercent: BATTERY_PROPERTY_CAPACITY. capacity: BATTERY_PROPERTY_CHARGE_COUNTER. isRechargeable: always true. chargeState: BATTERY_STATUS_CHARGING, BATTERY_STATUS_DISCHARGING, BATTERY_STATUS_FULL and BATTERY_STATUS_NOT_CHARGING; BATTERY_STATUS_UNKNOWN can also be used, but Solid does not expose such a value.


- Lamarque


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123263/#review78531
-----------------------------------------------------------


On April 5, 2015, 8:56 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123263/
> -----------------------------------------------------------
> 
> (Updated April 5, 2015, 8:56 p.m.)
> 
> 
> Review request for kdeconnect, Solid, Albert Vaca Cintora, and Emmanuel Pescosta.
> 
> 
> Repository: solid
> 
> 
> Description
> -------
> 
> This adds a KDE Connect backend to Solid enabling us to show phone battery status in the device notifier, and have the phone appear in the device notifier like an external storage.
> 
> It is pretty synchronous at the moment. Any ideas how I could improve that? I guess when someone wants to get devices, it creates a new device interface and calls allDevices() or devicesFromQuery() immediately afterwards, so I cannot just do that stuff async and defer population? Or call deviceAdded for each of the initial ones once I have them?
> 
> It requires adjustment in the kdeconnect KIO slave so it can handle addresses like kdeconnect://org/kde/kdeconnect/123456 or kdeconnect:udi=/org/kde/kdeconnect/123456 (like mtp kio does) because all Dolphin or the device notifier have is the UDI. It also needs a new device action that matches "Portable Media Player" with the "kdeconnect" protocol, similar to mtp.
> 
> By adjusting the predicate in Dolphin's Places sidebar (and probably the file dialog) to query for the "kdeconnect" protocol, we can have its places automatically updated without having KDE Connect manually mess with KFilePlaces.
> 
> 
> Diffs
> -----
> 
>   src/solid/devices/CMakeLists.txt 9271ae1 
>   src/solid/devices/backends/kdeconnect/CMakeLists.txt PRE-CREATION 
>   src/solid/devices/backends/kdeconnect/kdeconnectbattery.h PRE-CREATION 
>   src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp PRE-CREATION 
>   src/solid/devices/backends/kdeconnect/kdeconnectdevice.h PRE-CREATION 
>   src/solid/devices/backends/kdeconnect/kdeconnectdevice.cpp PRE-CREATION 
>   src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.h PRE-CREATION 
>   src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.cpp PRE-CREATION 
>   src/solid/devices/backends/kdeconnect/kdeconnectmanager.h PRE-CREATION 
>   src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp PRE-CREATION 
>   src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.h PRE-CREATION 
>   src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.cpp PRE-CREATION 
>   src/solid/devices/managerbase.cpp eee4de5 
> 
> Diff: https://git.reviewboard.kde.org/r/123263/diff/
> 
> 
> Testing
> -------
> 
> With some crash fixes already pushed to plasma-workspace it works pretty well.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150419/7f3eff18/attachment.html>