Review Request 123361: Make it possible to fetch the device from the DevicesModel from QML

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123361/#review78935
-----------------------------------------------------------

Ship it!


If the old getDevice was not used, then ship it! (Otherwise add a method with the old signature that calls the new method)


plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.cpp (line 64)
<https://git.reviewboard.kde.org/r/123361/#comment53964>

    Why do we use 'uri' in some cases and "org.kde.kdeconnect" in others? Shouldn't they all be 'uri'?


- Albert Vaca Cintora


On April 14, 2015, 9:33 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123361/
> -----------------------------------------------------------
> 
> (Updated April 14, 2015, 9:33 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Uses the row as the argument instead of the QModelIndex.
> Defines the Device type so it can be used from QML.
> 
> 
> Diffs
> -----
> 
>   interfaces/devicesmodel.h 1f157b2 
>   interfaces/devicesmodel.cpp 16b4d77 
>   plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.cpp 5b9716f 
> 
> Diff: https://git.reviewboard.kde.org/r/123361/diff/
> 
> 
> Testing
> -------
> 
> My Purpose plugin works.
> https://projects.kde.org/projects/playground/libs/purpose
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150414/91444351/attachment.html>