Review Request 123325: Drop dependency of KIO from kdeconnectcore

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123325/
-----------------------------------------------------------

(Updated April 14, 2015, 4:42 a.m.)


Review request for kdeconnect.


Changes
-------

Iteration

* Put a buffer in the middle, downloads first in memory then dumps it into the destination. (meh)
* Works
* Only works with QNetworkAccessManager, not KIO::AccessManager (meh)


Repository: kdeconnect-kde


Description
-------

Use QNetworkAccessManager for storing the files we receive instead of directly KIO, then provide the KIO-based QNetworkAccessManager from the daemon. This way we'll still get the KIO network-transparency, but the library only depenends on QtNetwork, which will be easier to get in some platforms.

After this change, we only depend on KConfig, KI18n and KCoreAddons, which are tier1 and really easy to work with on any platform.


Diffs (updated)
-----

  CMakeLists.txt dbaa039 
  core/CMakeLists.txt f465959 
  core/daemon.h 654441f 
  core/filetransferjob.h 973bd3a 
  core/filetransferjob.cpp 27ed8e8 
  daemon/CMakeLists.txt 852e779 
  daemon/kdeconnectd.cpp 25632fd 

Diff: https://git.reviewboard.kde.org/r/123325/diff/


Testing
-------

None, don't give a ship it. I only worked on it on the airplane, so I couldn't test it. If somebody wants to help with the testing, I'll welcome it.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150414/7736f81d/attachment.html>