Review Request 123345: Find my phone plugin for kdeconnect android

Ashish Bansal bansal.ashish096 at gmail.com
Sun Apr 12 17:56:46 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123345/
-----------------------------------------------------------

Review request for kdeconnect, Albert Vaca Cintora and Aleix Pol Gonzalez.


Repository: kdeconnect-android


Description
-------

When invoked, this plugin plays phone's default ringtone at max volume even if it's at silent and turns if off on touching the Notification.


Diffs
-----

  AndroidManifest.xml 556b06b 
  res/values/strings.xml 6984ce6 
  src/org/kde/kdeconnect/NetworkPackage.java e5a777e 
  src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhonePlugin.java PRE-CREATION 
  src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/PhoneFound.java PRE-CREATION 
  src/org/kde/kdeconnect/Plugins/PluginFactory.java 0100690 

Diff: https://git.reviewboard.kde.org/r/123345/diff/


Testing
-------

Works Fine.


Thanks,

Ashish Bansal

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150412/4e36c76d/attachment.html>


More information about the KDEConnect mailing list