Review Request 123339: Fixed full screen on mousepad activity.

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123339/#review78843
-----------------------------------------------------------


Sorry, don't ship it yet, it doesn't work: when you open the keyboard or the context menu, it goes back to non-fullscreen. Can you fix that?

- Albert Vaca Cintora


On abr. 11, 2015, 1:17 p.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123339/
> -----------------------------------------------------------
> 
> (Updated abr. 11, 2015, 1:17 p.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Bugs: 346027
>     http://bugs.kde.org/show_bug.cgi?id=346027
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Well I am not sure why setOnSystemUiVisibilityChangeListener was used (and if that code has been used for some other intented purpose, not for fullscreen?) as according to [1], callback is invoked when status bar changes visibility.
> 
> And if it was intended for making activity fullscreen, then this patch works fine. 
> 
> [1] http://developer.android.com/reference/android/view/View.OnSystemUiVisibilityChangeListener.html
> 
> 
> Diffs
> -----
> 
>   src/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadActivity.java 9e6aab7 
> 
> Diff: https://git.reviewboard.kde.org/r/123339/diff/
> 
> 
> Testing
> -------
> 
> Works fine, hides both navigation and status bars.
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150412/ade6e8eb/attachment.html>