Review Request 123339: Fixed full screen on mousepad activity.

Ashish Bansal bansal.ashish096 at gmail.com
Sat Apr 11 20:17:10 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123339/
-----------------------------------------------------------

Review request for kdeconnect and Albert Vaca Cintora.


Bugs: 346027
    http://bugs.kde.org/show_bug.cgi?id=346027


Repository: kdeconnect-android


Description
-------

Well I am not sure why setOnSystemUiVisibilityChangeListener was used (and if that code has been used for some other intented purpose, not for fullscreen?) as according to [1], callback is invoked when status bar changes visibility.

And if it was intended for making activity fullscreen, then this patch works fine. 

[1] http://developer.android.com/reference/android/view/View.OnSystemUiVisibilityChangeListener.html


Diffs
-----

  src/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadActivity.java 9e6aab7 

Diff: https://git.reviewboard.kde.org/r/123339/diff/


Testing
-------

Works fine, hides both navigation and status bars.


Thanks,

Ashish Bansal

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150411/b51f1373/attachment.html>


More information about the KDEConnect mailing list