Review Request 123325: Drop dependency of KIO from kdeconnectcore
Aleix Pol Gonzalez
aleixpol at kde.org
Fri Apr 10 16:16:18 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123325/
-----------------------------------------------------------
Review request for kdeconnect.
Repository: kdeconnect-kde
Description
-------
Use QNetworkAccessManager for storing the files we receive instead of directly KIO, then provide the KIO-based QNetworkAccessManager from the daemon. This way we'll still get the KIO network-transparency, but the library only depenends on QtNetwork, which will be easier to get in some platforms.
After this change, we only depend on KConfig, KI18n and KCoreAddons, which are tier1 and really easy to work with on any platform.
Diffs
-----
CMakeLists.txt dbaa039
core/CMakeLists.txt f465959
core/daemon.h 654441f
core/filetransferjob.h 973bd3a
core/filetransferjob.cpp 27ed8e8
daemon/CMakeLists.txt 852e779
daemon/kdeconnectd.cpp 25632fd
Diff: https://git.reviewboard.kde.org/r/123325/diff/
Testing
-------
None, don't give a ship it. I only worked on it on the airplane, so I couldn't test it. If somebody wants to help with the testing, I'll welcome it.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150410/98482c47/attachment.html>
More information about the KDEConnect
mailing list