Review Request 123308: KCM: Use currentChanged signal instead of clicked in deviceList

Aleix Pol Gonzalez aleixpol at kde.org
Thu Apr 9 14:54:23 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123308/#review78715
-----------------------------------------------------------

Ship it!


Good catch!

- Aleix Pol Gonzalez


On April 9, 2015, 3:53 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123308/
> -----------------------------------------------------------
> 
> (Updated April 9, 2015, 3:53 p.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Using currentChanged signal it is now possible to select devices with keyboard.
> It also no longer refreshes plugin info when clicking on already selected device.
> 
> 
> Diffs
> -----
> 
>   kcm/kcm.cpp e053aca 
> 
> Diff: https://git.reviewboard.kde.org/r/123308/diff/
> 
> 
> Testing
> -------
> 
> Works as intended
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150409/6674b82c/attachment.html>


More information about the KDEConnect mailing list