Review Request 123263: WIP: KDE Connect backend for Solid

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123263/#review78611
-----------------------------------------------------------



src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp (line 29)
<https://git.reviewboard.kde.org/r/123263/#comment53779>

    iirc this will block if dbus is frozen.



src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp (line 154)
<https://git.reviewboard.kde.org/r/123263/#comment53780>

    All this empty strings could be replaced with some hardcoded literal.


- Àlex Fiestas


On abr. 5, 2015, 8:56 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123263/
> -----------------------------------------------------------
> 
> (Updated abr. 5, 2015, 8:56 p.m.)
> 
> 
> Review request for kdeconnect, Solid, Albert Vaca Cintora, and Emmanuel Pescosta.
> 
> 
> Repository: solid
> 
> 
> Description
> -------
> 
> This adds a KDE Connect backend to Solid enabling us to show phone battery status in the device notifier, and have the phone appear in the device notifier like an external storage.
> 
> It is pretty synchronous at the moment. Any ideas how I could improve that? I guess when someone wants to get devices, it creates a new device interface and calls allDevices() or devicesFromQuery() immediately afterwards, so I cannot just do that stuff async and defer population? Or call deviceAdded for each of the initial ones once I have them?
> 
> It requires adjustment in the kdeconnect KIO slave so it can handle addresses like kdeconnect://org/kde/kdeconnect/123456 or kdeconnect:udi=/org/kde/kdeconnect/123456 (like mtp kio does) because all Dolphin or the device notifier have is the UDI. It also needs a new device action that matches "Portable Media Player" with the "kdeconnect" protocol, similar to mtp.
> 
> By adjusting the predicate in Dolphin's Places sidebar (and probably the file dialog) to query for the "kdeconnect" protocol, we can have its places automatically updated without having KDE Connect manually mess with KFilePlaces.
> 
> 
> Diffs
> -----
> 
>   src/solid/devices/CMakeLists.txt 9271ae1 
>   src/solid/devices/backends/kdeconnect/CMakeLists.txt PRE-CREATION 
>   src/solid/devices/backends/kdeconnect/kdeconnectbattery.h PRE-CREATION 
>   src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp PRE-CREATION 
>   src/solid/devices/backends/kdeconnect/kdeconnectdevice.h PRE-CREATION 
>   src/solid/devices/backends/kdeconnect/kdeconnectdevice.cpp PRE-CREATION 
>   src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.h PRE-CREATION 
>   src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.cpp PRE-CREATION 
>   src/solid/devices/backends/kdeconnect/kdeconnectmanager.h PRE-CREATION 
>   src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp PRE-CREATION 
>   src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.h PRE-CREATION 
>   src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.cpp PRE-CREATION 
>   src/solid/devices/managerbase.cpp eee4de5 
> 
> Diff: https://git.reviewboard.kde.org/r/123263/diff/
> 
> 
> Testing
> -------
> 
> With some crash fixes already pushed to plasma-workspace it works pretty well.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150407/b1c01aa8/attachment.html>