Review Request 123225: Check if file exists or not, and then call suggestName.
Aleix Pol Gonzalez
aleixpol at kde.org
Thu Apr 2 12:39:50 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123225/#review78403
-----------------------------------------------------------
plugins/share/shareplugin.cpp (line 95)
<https://git.reviewboard.kde.org/r/123225/#comment53647>
Ugh sorry, scratch that.
- Aleix Pol Gonzalez
On April 2, 2015, 2:27 p.m., Ashish Bansal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123225/
> -----------------------------------------------------------
>
> (Updated April 2, 2015, 2:27 p.m.)
>
>
> Review request for kdeconnect, Albert Vaca Cintora and Aleix Pol Gonzalez.
>
>
> Repository: kdeconnect-kde
>
>
> Description
> -------
>
> KIO::suggestName does not checks if file with passed name exists or not. So, we need to check it
>
>
> Diffs
> -----
>
> plugins/share/shareplugin.cpp 65d07f0
>
> Diff: https://git.reviewboard.kde.org/r/123225/diff/
>
>
> Testing
> -------
>
> Works fine!
>
>
> Thanks,
>
> Ashish Bansal
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150402/bfcd1b87/attachment.html>
More information about the KDEConnect
mailing list