Review Request 123215: Use KIO::suggestName instead of the copied code

Ashish Bansal bansal.ashish096 at gmail.com
Thu Apr 2 11:27:48 UTC 2015



> On April 2, 2015, 9:06 a.m., Ashish Bansal wrote:
> > KIO::suggestName gives wrong name if filename is like filename.5.3.2.tar.gz. Older code is also giving wrong name for this type of filename.
> > I have fixed it using this: http://ix.io/hgx 
> > So, should I post it for review?
> 
> Aleix Pol Gonzalez wrote:
>     I would prefer it if you fixed it over in KIO.

Okay cool


- Ashish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123215/#review78393
-----------------------------------------------------------


On April 1, 2015, 9:41 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123215/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 9:41 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Upstream FTW.
> 
> 
> Diffs
> -----
> 
>   plugins/share/shareplugin.cpp 5a19b30 
> 
> Diff: https://git.reviewboard.kde.org/r/123215/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150402/9b45bdb6/attachment.html>


More information about the KDEConnect mailing list