Review Request 123214: Fix file transfer

Aleix Pol Gonzalez aleixpol at kde.org
Wed Apr 1 21:41:10 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123214/
-----------------------------------------------------------

(Updated April 1, 2015, 9:41 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdeconnect.


Changes
-------

Submitted with commit 9ab7e2356e9d698a378e85b511269784c9f06828 by Aleix Pol to branch master.


Repository: kdeconnect-kde


Description
-------

The actual fix is the addition of the 2 properties in NetworkPackage.

It also changes it to use the correct QMetaObject API's for setting the property values by saving a void fetch just to get the type and letting QMetaObject do the cast itself.


Diffs
-----

  core/networkpackage.h 83aa8b4 
  core/networkpackage.cpp 6f7e62e 

Diff: https://git.reviewboard.kde.org/r/123214/diff/


Testing
-------

I sent a file and I liked it.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150401/aa3f5bf6/attachment-0001.html>


More information about the KDEConnect mailing list