Review Request 123214: Fix file transfer

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123214/#review78371
-----------------------------------------------------------

Ship it!


Looks fine but this doesn't seem to be the problem. Did you test if this makes any difference?


core/networkpackage.h (lines 46 - 47)
<https://git.reviewboard.kde.org/r/123214/#comment53641>

    If this is needed for qvariant2qobject, it seems impossible to me that it ever worked as it would have never accessed the payloadTransferInfo.


- Albert Vaca Cintora


On April 1, 2015, 9:23 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123214/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 9:23 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> The actual fix is the addition of the 2 properties in NetworkPackage.
> 
> It also changes it to use the correct QMetaObject API's for setting the property values by saving a void fetch just to get the type and letting QMetaObject do the cast itself.
> 
> 
> Diffs
> -----
> 
>   core/networkpackage.h 83aa8b4 
>   core/networkpackage.cpp 6f7e62e 
> 
> Diff: https://git.reviewboard.kde.org/r/123214/diff/
> 
> 
> Testing
> -------
> 
> I sent a file and I liked it.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150401/87604d68/attachment-0001.html>