Review Request 123215: Use KIO::suggestName instead of the copied code

Ashish Bansal bansal.ashish096 at gmail.com
Wed Apr 1 17:44:08 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123215/#review78372
-----------------------------------------------------------



plugins/share/shareplugin.cpp (line 93)
<https://git.reviewboard.kde.org/r/123215/#comment53642>

    I think suggestName only returns filename. It should be appended to dir to get full destination URL.


- Ashish Bansal


On April 1, 2015, 5:34 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123215/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 5:34 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Upstream FTW.
> 
> 
> Diffs
> -----
> 
>   plugins/share/shareplugin.cpp 5a19b30 
> 
> Diff: https://git.reviewboard.kde.org/r/123215/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150401/2e8bbc8c/attachment.html>


More information about the KDEConnect mailing list