Review Request 120005: Plugins specific settings

[Aleix Pol Gonzalez]

> On Aug. 31, 2014, 12:04 a.m., Aleix Pol Gonzalez wrote:
> > src/main/res/values/strings.xml, line 76
> > <https://git.reviewboard.kde.org/r/120005/diff/2/?file=308640#file308640line76>
> >
> >     Is that really something you'd want as a configuration? Maybe the UI should just be extended?
> 
> Albert Vaca Cintora wrote:
>     I like the patch to be able to have settings per-plugin, and even though I agree with you that this doesn't make much sense as a setting, I can't see a way to put it in the normal UI. Do you have any idea?
> 
> Aleix Pol Gonzalez wrote:
>     A long tap could open a dialog asking how much it needs to jump, for example.
> 
> Ronny  Yabar Aizcorbe wrote:
>     Yes, because maybe in the future, there will be other settings to add.

That's not how engineering works. You don't do things in case you need them eventually, but you do the things you need.

If you guys agree this is needed I won't oppose, but I don't really see it yet.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120005/#review65566
-----------------------------------------------------------


On Aug. 30, 2014, 4:04 p.m., Ronny  Yabar Aizcorbe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120005/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2014, 4:04 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Added support for specific plugin UI settings. Added interval time preferences to fast forward or rewind a multimedia file instead of harcording the time.
> 
> 
> Diffs
> -----
> 
>   src/main/AndroidManifest.xml 499e92e 
>   src/main/java/org/kde/kdeconnect/Plugins/BatteryPlugin/BatteryPlugin.java 7761c21 
>   src/main/java/org/kde/kdeconnect/Plugins/ClibpoardPlugin/ClipboardPlugin.java 68315ff 
>   src/main/java/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadPlugin.java 491e694 
>   src/main/java/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java b219e07 
>   src/main/java/org/kde/kdeconnect/Plugins/MprisPlugin/MprisPlugin.java 3884392 
>   src/main/java/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java adc4825 
>   src/main/java/org/kde/kdeconnect/Plugins/PingPlugin/PingPlugin.java 51d2028 
>   src/main/java/org/kde/kdeconnect/Plugins/Plugin.java a91016a 
>   src/main/java/org/kde/kdeconnect/Plugins/PluginFactory.java 8d046cc 
>   src/main/java/org/kde/kdeconnect/Plugins/SftpPlugin/SftpPlugin.java eee7bf9 
>   src/main/java/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java b0c28cb 
>   src/main/java/org/kde/kdeconnect/Plugins/TelephonyPlugin/TelephonyPlugin.java d26409a 
>   src/main/java/org/kde/kdeconnect/UserInterface/PluginSettingsActivity.java PRE-CREATION 
>   src/main/java/org/kde/kdeconnect/UserInterface/SettingsActivity.java e1599c5 
>   src/main/res/values/arrays.xml PRE-CREATION 
>   src/main/res/values/strings.xml bec4a22 
>   src/main/res/xml/plugin_mpris_preferences.xml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120005/diff/
> 
> 
> Testing
> -------
> 
> Checked and tested. Works well.
> 
> 
> Thanks,
> 
> Ronny  Yabar Aizcorbe
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140906/f4fecd2b/attachment.html>