Review Request 116843: NotificationPlugin: Using Notification.extras on KitKat for a better ticker text.

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116843/#review54392
-----------------------------------------------------------

Ship it!


Nice patch! I've been using it for a couple of days and it's really a big improvement. For example I noticed that Whatsapp messages are fully displayed in KDE now, thanks to your patch :D It seems that you don't have commit rights in KDE yet, so let me merge it to the master branch on your name, and make a release to the Play Store. And sorry for the late review... I don't have much time for KDE Connect recently :(

- Albert Vaca Cintora


On March 16, 2014, 8:40 p.m., Sven Nobis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116843/
> -----------------------------------------------------------
> 
> (Updated March 16, 2014, 8:40 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Many Apps don't set a useful ticker text. On Android version KitKat or newer, the title and text of a notification is stored in the extras Bundle. This patch make use of it, to provide a better ticker text.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java fa641d8 
> 
> Diff: https://git.reviewboard.kde.org/r/116843/diff/
> 
> 
> Testing
> -------
> 
> Tested on Nexus 4 with Android KitKat.
> 
> 
> Thanks,
> 
> Sven Nobis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140327/7eaf66a3/attachment.html>