Review Request 116698: Fix crash when user tries to unload plugin, which is not supported by platform.

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116698/#review52562
-----------------------------------------------------------

Ship it!


Thank you! Will commit it as soon as I can.

- Albert Vaca Cintora


On March 10, 2014, 5:45 p.m., Mariusz Fik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116698/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 5:45 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Fix crash when user tries to unload plugin, which is not supported by platform.
> 
> Signed-off-by: Mariusz Fik <fisiu at opensuse.org>
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java fa641d88a95ec967f79f1266333c74be0a74db5a 
> 
> Diff: https://git.reviewboard.kde.org/r/116698/diff/
> 
> 
> Testing
> -------
> 
> Before this change, I got:
> 03-10 13:14:12.772    1320-1320/org.kde.kdeconnect_tp E/AndroidRuntime? FATAL EXCEPTION: main
>     java.lang.NoClassDefFoundError: org.kde.kdeconnect.Plugins.NotificationsPlugin.NotificationReceiver
>             at org.kde.kdeconnect.Plugins.NotificationsPlugin.NotificationsPlugin.onDestroy(NotificationsPlugin.java:152)
>             at org.kde.kdeconnect.Device.removePlugin(Device.java:591)
>             at org.kde.kdeconnect.Device.setPluginEnabled(Device.java:611)
>             at org.kde.kdeconnect.UserInterface.SettingsActivity$1$1.onItemClick(SettingsActivity.java:56)
> 
> After fix, user can toggle notification plugin in settings, without a crash.
> 
> 
> Thanks,
> 
> Mariusz Fik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140310/2f650622/attachment-0001.html>