Review Request 116687: Load NotificationsPlugin only when device has android 4.3 or newer.

[Albert Vaca Cintora]

> On March 10, 2014, 10:47 a.m., Albert Vaca Cintora wrote:
> > I prefer the plugin to appear in the list, even if it does not work on devices <4.3. There is a message explaining the user that this plugin won't work on the given Android version, so it's not a problem to load it.
> 
> Mariusz Fik wrote:
>     Ok. What about disabling it in listview? It could be still visible, but not accepting user input. Something like that: http://img819.imageshack.us/img819/4577/n0rl.png
>     Now, if user has android < 4.3, enabling and disabling notifications plugin end with:
>     
>     03-10 13:14:12.772    1320-1320/org.kde.kdeconnect_tp E/AndroidRuntime? FATAL EXCEPTION: main
>         java.lang.NoClassDefFoundError: org.kde.kdeconnect.Plugins.NotificationsPlugin.NotificationReceiver
>                 at org.kde.kdeconnect.Plugins.NotificationsPlugin.NotificationsPlugin.onDestroy(NotificationsPlugin.java:152)
>                 at org.kde.kdeconnect.Device.removePlugin(Device.java:591)
>                 at org.kde.kdeconnect.Device.setPluginEnabled(Device.java:611)
>                 at org.kde.kdeconnect.UserInterface.SettingsActivity$1$1.onItemClick(SettingsActivity.java:56)

Then this is a bug that we have to fix. It should not crash, simply not load and display the explanation message.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116687/#review52496
-----------------------------------------------------------


On March 10, 2014, 2:36 a.m., Mariusz Fik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116687/
> -----------------------------------------------------------
> 
> (Updated March 10, 2014, 2:36 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Load NotificationsPlugin only when device has android 4.3 or newer.
> 
> Signed-off-by: Mariusz Fik <fisiu at opensuse.org>
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/kde/kdeconnect/Plugins/PluginFactory.java 00019b1c18d8bcdf8e2317e62eabea729e6f6452 
> 
> Diff: https://git.reviewboard.kde.org/r/116687/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mariusz Fik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140310/13513ab0/attachment.html>