Review Request 116687: Load NotificationsPlugin only when device has android 4.3 or newer.
Albert Vaca Cintora
albertvaka at gmail.com
Mon Mar 10 09:47:55 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116687/#review52496
-----------------------------------------------------------
I prefer the plugin to appear in the list, even if it does not work on devices <4.3. There is a message explaining the user that this plugin won't work on the given Android version, so it's not a problem to load it.
- Albert Vaca Cintora
On March 10, 2014, 2:36 a.m., Mariusz Fik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116687/
> -----------------------------------------------------------
>
> (Updated March 10, 2014, 2:36 a.m.)
>
>
> Review request for kdeconnect.
>
>
> Repository: kdeconnect-android
>
>
> Description
> -------
>
> Load NotificationsPlugin only when device has android 4.3 or newer.
>
> Signed-off-by: Mariusz Fik <fisiu at opensuse.org>
>
>
> Diffs
> -----
>
> src/main/java/org/kde/kdeconnect/Plugins/PluginFactory.java 00019b1c18d8bcdf8e2317e62eabea729e6f6452
>
> Diff: https://git.reviewboard.kde.org/r/116687/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mariusz Fik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140310/64e0926f/attachment.html>
More information about the KDEConnect
mailing list