Review Request 116484: Simplify path handling

Aleix Pol Gonzalez aleixpol at kde.org
Sat Mar 1 23:50:25 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116484/
-----------------------------------------------------------

(Updated March 1, 2014, 11:50 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdeconnect.


Repository: kdeconnect-kde


Description
-------

- prefer ::toLocalFile() to ::path(). ::path() won't work on Windows properly.
- let KUrl handle the trailing slash adjusting, no need to do the string handling ourselves.
- take advantage of the fact that it can be a url, at the moment it was just doing silly type conversions.


Diffs
-----

  kded/plugins/share/shareplugin.h 119658f 
  kded/plugins/share/shareplugin.cpp 306a228 

Diff: https://git.reviewboard.kde.org/r/116484/diff/


Testing
-------


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140301/613858ad/attachment.html>


More information about the KDEConnect mailing list