Review Request 113344: Make it possible to send files from kdeconnect-kde

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113344/
-----------------------------------------------------------

(Updated March 1, 2014, 11:48 p.m.)


Review request for kdeconnect and Albert Vaca Cintora.


Changes
-------

Now I actually sent a file successfully from KDE -> KDE.
The payload size wasn't being passed, it was set to 0 for some reason. Also we weren't starting to read the file, so it got stuck.

Additionally, now we're passing a filename.


Repository: kdeconnect-kde


Description
-------

Register the share plugin so that it can be accessed and exposes a function that will send a file to the corresponding plugin device.

Only proof of concept, I wrote it on a plane, couldn't really try it, but still I'd like to get some feedback.


Diffs (updated)
-----

  kded/backends/lan/uploadjob.cpp ae055cb 
  kded/networkpackage.cpp cca7929 
  kded/plugins/share/shareplugin.h 119658f 
  kded/plugins/share/shareplugin.cpp 480faef 

Diff: https://git.reviewboard.kde.org/r/113344/diff/


Testing
-------

None.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140301/bd3f3076/attachment.html>