Review Request 119007: Implement two thumb scrolling on Android

[Albert Vaca Cintora]

> On June 29, 2014, 12:51 p.m., Albert Vaca Cintora wrote:
> > Please remove or comment the Log.v line before committing the change.
> > 
> > And also note that I changed the function getErrorDialog() in master branch to return null since it was not being used, take it into account when merging it.
> 
> Ahmed I. Khalil wrote:
>     Okay, I'll take that into account. 
>     But I'd like to ask you, have you tried the change yourself? What do you think of the scrolling experience ?
> 
> Albert Vaca Cintora wrote:
>     I think it can be improved, but it's good enough to release it (release early, release often!). I made some changes already to fix a problem with the mouse being "jumpy" sometimes while scrolling and also adjusting the scroll velocity. I added your address as CCMAIL for you to see these changes.
> 
> Ahmed I. Khalil wrote:
>     Please don't release before, implementing the right and middle clicks, I've implemented those two on Android, as a Menu Items that is shown from the settings button.
>     A review request is right a way

I just added support for those in the KDE side, so I think you will only need to change the Android client. Please make sure to pull the latest version from both repos, so you get all the changes!


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119007/#review61164
-----------------------------------------------------------


On June 29, 2014, 5:17 p.m., Ahmed I. Khalil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119007/
> -----------------------------------------------------------
> 
> (Updated June 29, 2014, 5:17 p.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Implement two thumb scrolling on Android, by handling the onScroll method that it is called from the GestureDetector.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadActivity.java d91c09f 
>   src/main/java/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadPlugin.java f8ac4d9 
> 
> Diff: https://git.reviewboard.kde.org/r/119007/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ahmed I. Khalil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140629/9718c7e6/attachment.html>