Review Request 119007: Implement two thumb scrolling on Android

[Ahmed I. Khalil]

> On June 29, 2014, 12:51 p.m., Albert Vaca Cintora wrote:
> > Please remove or comment the Log.v line before committing the change.
> > 
> > And also note that I changed the function getErrorDialog() in master branch to return null since it was not being used, take it into account when merging it.

Okay, I'll take that into account. 
But I'd like to ask you, have you tried the change yourself? What do you think of the scrolling experience ?


- Ahmed


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119007/#review61164
-----------------------------------------------------------


On June 29, 2014, 12:24 a.m., Ahmed I. Khalil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119007/
> -----------------------------------------------------------
> 
> (Updated June 29, 2014, 12:24 a.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Implement two thumb scrolling on Android, by handling the onScroll method that it is called from the GestureDetector.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadActivity.java d91c09f 
>   src/main/java/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadPlugin.java f8ac4d9 
> 
> Diff: https://git.reviewboard.kde.org/r/119007/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ahmed I. Khalil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140629/5bcd0885/attachment-0001.html>