Review Request 118870: LanLinkProvider: Bind the UDP server socket to Any, not Broadcast.

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118870/#review60909
-----------------------------------------------------------

Ship it!


Thanks for your explanation, feel free to merge this change. The original intention of that code was to listen ONLY to broadcast messages, but as you explained this is not the way to do it. Do you know if there is any way to do what we wanted?

- Albert Vaca Cintora


On June 22, 2014, 3:44 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118870/
> -----------------------------------------------------------
> 
> (Updated June 22, 2014, 3:44 p.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Bugs: 324769
>     http://bugs.kde.org/show_bug.cgi?id=324769
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Trying to bind a UDP socket to 255.255.255.255 fails with EADDRNOTAVAIL at least on FreeBSD.
> 
> The sender side on Android should send its message in broadcast mode (as it already does), but the receiver side should bind to INADDR_ANY, not INADDR_BROADCAST.
> 
> 
> Diffs
> -----
> 
>   core/backends/lan/lanlinkprovider.cpp 2369dc4487c17a99215047c767dbe8232ded1d92 
> 
> Diff: https://git.reviewboard.kde.org/r/118870/diff/
> 
> 
> Testing
> -------
> 
> kdeconnectd no longer crashes on startup and I can pair my device on FreeBSD.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140624/92bb3bd7/attachment.html>