Review Request 118820: Use the incoming/outgoing capabilities for trimming what plugins are loaded for a said device.

Albert Vaca Cintora albertvaka at gmail.com
Sat Jun 21 01:39:37 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118820/#review60633
-----------------------------------------------------------

Ship it!


Better do this change in a sepparate branch. It could introduce problems and actually we don't require this functionality right now in the master branch for the upcoming release.

- Albert Vaca Cintora


On June 19, 2014, 2:54 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118820/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 2:54 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Only lets the plugins that support something offered on the other end or that offer something supported on the other end. If we don't have information about the other device, we enable everything like we used to.
> 
> Also refactors a bit the plugin loader, to be able to provide information step by step.
> 
> 
> Diffs
> -----
> 
>   core/device.h ec757b8 
>   core/device.cpp 29982e7 
>   core/networkpackage.cpp e027f50 
>   core/pluginloader.h 4983730 
>   core/pluginloader.cpp 1c10c07 
> 
> Diff: https://git.reviewboard.kde.org/r/118820/diff/
> 
> 
> Testing
> -------
> 
> It builds, didn't try.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140621/a7859899/attachment-0001.html>


More information about the KDEConnect mailing list