Review Request 118807: Specify the username with the device name

[Albert Vaca Cintora]

> On June 18, 2014, 5:05 a.m., Albert Vaca Cintora wrote:
> > I think you want to change the device ID (so the phone doesn't try to connect to a computer when it's used by a different user), not the device name (that is only a visual information).
> 
> Aleix Pol Gonzalez wrote:
>     Well, if it's 2 users, then it will be 2 devices ID. Different users will have different device ID anyway, but they will be shown with the same device name, ending up with a list of the same name twice but still different devices.

Sorry, I didn't remember that device IDs would already be different. In that case ship it!


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118807/#review60346
-----------------------------------------------------------


On June 18, 2014, 2:57 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118807/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 2:57 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> So far, we're using only the hostname to specify the id, this patch adds the username as well.
> 
> I'm unsure whether it's a good use case or it's just that I'm a weird user.
> 
> It can be good in case it's used in a system with different users, so that we get to know which one is actually trying to reach.
> 
> 
> Diffs
> -----
> 
>   core/networkpackage.cpp e027f50 
> 
> Diff: https://git.reviewboard.kde.org/r/118807/diff/
> 
> 
> Testing
> -------
> 
> I see the new name on my phone.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140620/32b411ad/attachment.html>