Review Request 118807: Specify the username with the device name

Aleix Pol Gonzalez aleixpol at kde.org
Wed Jun 18 00:57:01 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118807/
-----------------------------------------------------------

Review request for kdeconnect.


Repository: kdeconnect-kde


Description
-------

So far, we're using only the hostname to specify the id, this patch adds the username as well.

I'm unsure whether it's a good use case or it's just that I'm a weird user.

It can be good in case it's used in a system with different users, so that we get to know which one is actually trying to reach.


Diffs
-----

  core/networkpackage.cpp e027f50 

Diff: https://git.reviewboard.kde.org/r/118807/diff/


Testing
-------

I see the new name on my phone.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140618/b1a51746/attachment.html>


More information about the KDEConnect mailing list