Review Request 118774: Figure out Messages.sh after code refactoring

[Albert Astals Cid]

> On June 16, 2014, 6:29 p.m., Albert Astals Cid wrote:
> > core/Messages.sh, line 4
> > <https://git.reviewboard.kde.org/r/118774/diff/3/?file=281672#file281672line4>
> >
> >     Ultra confused about this, why is it a two step process? One for rc.cpp and another for all the rest of cpp files? Also you don't need to remove rc.cpp, the script does it for you
> 
> Aleix Pol Gonzalez wrote:
>     We used to have only KDED, now we have kded, core (which is a library) and plugins, so we decided to change them all.
>     
>     Is it correct?
> 
> Albert Astals Cid wrote:
>     I mean why
>     
>     $EXTRACTRC `find . -name '*.ui' -o -name '*.rc'` >> rc.cpp
>     $XGETTEXT rc.cpp -o $podir/kdeconnect-core.pot
>     rm -f rc.cpp
>     
>     touch $podir/kdeconnect-core.pot
>     #.cpp (-j passed to merge into existing file)
>     $XGETTEXT `find . -name '*.cpp'` -j -o $podir/kdeconnect-core.pot
>     
>     Instead of just 
>     $EXTRACTRC `find . -name '*.ui' -o -name '*.rc'` >> rc.cpp
>     $XGETTEXT `find . -name '*.cpp'` -o $podir/kdeconnect-core.pot
>     Like every other project does?
>
> 
> Albert Vaca Cintora wrote:
>     Well, not "every other project": the project I copied it from didn't.
>     
>     And about deleting the rc.cpp... I created it, I delete it. It's not a bad thing to do your own housekeeping even if it's not needed :)

The thing is that you don't create them, it's already created, that's the reason you need to use >> and not >, so applying your logic you should do what i say and not remove the file, but wathever.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118774/#review60208
-----------------------------------------------------------


On June 17, 2014, 4:46 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118774/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 4:46 p.m.)
> 
> 
> Review request for kdeconnect, Albert Astals Cid and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> kded is translated again
> Rename the core's pot to kdeconnect-core.pot and make sure the library loads the catalog when it's linked to.
> 
> Ideally we would have a Message.sh per plugin I guess, but I'm unsure this makes sense at the moment.
> 
> 
> Diffs
> -----
> 
>   core/Messages.sh 2a61de2 
>   core/daemon.cpp 4243ea9 
>   kded/Messages.sh PRE-CREATION 
>   plugins/Messages.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118774/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140617/a73eee87/attachment.html>