Review Request 118774: Figure out Messages.sh after code refactoring
Albert Vaca Cintora
albertvaka at gmail.com
Tue Jun 17 08:36:46 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118774/#review60223
-----------------------------------------------------------
Ship it!
Aleix, can you do the changes that Albert suggested, and then merge all the changes?
- Albert Vaca Cintora
On June 16, 2014, 12:15 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118774/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 12:15 p.m.)
>
>
> Review request for kdeconnect, Albert Astals Cid and Albert Vaca Cintora.
>
>
> Repository: kdeconnect-kde
>
>
> Description
> -------
>
> kded is translated again
> Rename the core's pot to kdeconnect-core.pot and make sure the library loads the catalog when it's linked to.
>
> Ideally we would have a Message.sh per plugin I guess, but I'm unsure this makes sense at the moment.
>
>
> Diffs
> -----
>
> core/Messages.sh 2a61de2
> core/daemon.cpp 4243ea9
> kded/Messages.sh PRE-CREATION
> plugins/Messages.sh PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/118774/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140617/b1614295/attachment-0001.html>
More information about the KDEConnect
mailing list