Review Request 118774: Figure out Messages.sh after code refactoring

[Aleix Pol Gonzalez]

> On June 16, 2014, 6:29 p.m., Albert Astals Cid wrote:
> > core/Messages.sh, line 4
> > <https://git.reviewboard.kde.org/r/118774/diff/3/?file=281672#file281672line4>
> >
> >     Ultra confused about this, why is it a two step process? One for rc.cpp and another for all the rest of cpp files? Also you don't need to remove rc.cpp, the script does it for you

We used to have only KDED, now we have kded, core (which is a library) and plugins, so we decided to change them all.

Is it correct?


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118774/#review60208
-----------------------------------------------------------


On June 16, 2014, 10:15 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118774/
> -----------------------------------------------------------
> 
> (Updated June 16, 2014, 10:15 a.m.)
> 
> 
> Review request for kdeconnect, Albert Astals Cid and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> kded is translated again
> Rename the core's pot to kdeconnect-core.pot and make sure the library loads the catalog when it's linked to.
> 
> Ideally we would have a Message.sh per plugin I guess, but I'm unsure this makes sense at the moment.
> 
> 
> Diffs
> -----
> 
>   core/Messages.sh 2a61de2 
>   core/daemon.cpp 4243ea9 
>   kded/Messages.sh PRE-CREATION 
>   plugins/Messages.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118774/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140616/4a096e8c/attachment.html>