Review Request 119254: Add support for receiving keyboard entries

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119254/#review63544
-----------------------------------------------------------


I don't like the special keys (modifiers) using "hardcoded" values (1, 1 << 1, 1 << 1 | 1...), but apart from that I like it better as well :)

Can you change the modifiers to use an enum (with the same values in Android and KDE)? This should make it simpler to check them when you receive them as well. You might want to assign specific int values to the enum so you can still use bitmask operations on them if you need to do it.

- Albert Vaca Cintora


On Jul. 30, 2014, 3:07 p.m., Saikrishna Arcot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119254/
> -----------------------------------------------------------
> 
> (Updated Jul. 30, 2014, 3:07 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Add support for receiving keyboard entries.
> 
> This patch gets the keyboard entries from the Android client and passes along the keycode.
> 
> The Android version is [here](https://git.reviewboard.kde.org/r/119255/).
> 
> 
> Diffs
> -----
> 
>   plugins/mousepad/mousepadplugin.h 64f5d880057820127788d7653796946bffcedafe 
>   plugins/mousepad/mousepadplugin.cpp 64aae5cc938e2630bde3f329ec01bcd9b8651ce5 
> 
> Diff: https://git.reviewboard.kde.org/r/119254/diff/
> 
> 
> Testing
> -------
> 
> Checked and tested. Backspace and enter keys don't work (yet), and special symbols aren't entered in. 
> 
> 
> Thanks,
> 
> Saikrishna Arcot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140731/c61acca7/attachment.html>