Review Request 119255: Add support for using the keyboard

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119255/#review62243
-----------------------------------------------------------

Ship it!


I think we can merge it  already and then see if we can make some improvements and fix the small problem you comment.

- Albert Vaca Cintora


On jul. 13, 2014, 6:15 a.m., Saikrishna Arcot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119255/
> -----------------------------------------------------------
> 
> (Updated jul. 13, 2014, 6:15 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Add support for using the keyboard.
> 
> This patch adds a menu entry to display the keyboard in the mousepad plugin and allow the user to send keystrokes. Dead keys are not yet supported, and behavior is unknown if entered.
> 
> The KDE version is [here](https://git.reviewboard.kde.org/r/119254/).
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadActivity.java 31985083d93b0ffc8d18086a7bd8a08aa82cbbd8 
>   src/main/java/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadPlugin.java 756e5e0919aa7d2847c5d4a5509bd662c3c72321 
>   src/main/res/menu/menu_mousepad.xml 294eba4b2c8a9ae494fb4a426204a92fa0d07168 
>   src/main/res/values/strings.xml 4ca395b8b00e1ca5b9336a65cc8da2e657a1dbfa 
> 
> Diff: https://git.reviewboard.kde.org/r/119255/diff/
> 
> 
> Testing
> -------
> 
> Compiled and tested on Android 4.1.2 to see that there are keys being read out. There is an oddity where the back button (at the top-left corner) is highlighted, and when exiting the app, the first app icon on the home screen is highlighted.
> 
> 
> Thanks,
> 
> Saikrishna Arcot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140713/aae7de49/attachment.html>