Review Request 119148: Set path to kdeconnectd executable through cmake

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119148/#review61765
-----------------------------------------------------------

Ship it!


We had that same problem with drkonqi, with the added complexity that drkonqi and KCrash are in different projects.

Here, I'd suggest to get Martin's solution in. A solution for properly supporting libexec is under discussion. In fact, libexec is not even standard and QStandardPaths doesn't support it.

Put it in a different way, this is the correct way of doing this in Qt 5.3 (we'll see 5.4 or 5.12)

- Aleix Pol Gonzalez


On July 6, 2014, 5:26 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119148/
> -----------------------------------------------------------
> 
> (Updated July 6, 2014, 5:26 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Set path to kdeconnectd executable through cmake
> 
> Libexec binaries need to be hardcoded, otherwise they are not found.
> This commit creates a config file and sets the path there.
> 
> 
> Diffs
> -----
> 
>   kded/CMakeLists.txt 73cf45b924101b3ce0f3f1fd96b64cdc964637e0 
>   kded/config-kded.h.cmake PRE-CREATION 
>   kded/kded.cpp 2ec9062e6f95bbe04d3eff18dcbf30c180a58bb5 
> 
> Diff: https://git.reviewboard.kde.org/r/119148/diff/
> 
> 
> Testing
> -------
> 
> daemon gets started by kded
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140707/86aa39ed/attachment.html>