Review Request 119091: TestSocketLineReader: Ensure we provide a more appropiate message if we fail trying to open a connection to the client

Aleix Pol Gonzalez aleixpol at kde.org
Wed Jul 2 20:37:41 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119091/#review61509
-----------------------------------------------------------

Ship it!


Submit it,  then we can all look into it? 

- Aleix Pol Gonzalez


On July 2, 2014, 6:56 p.m., David Suárez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119091/
> -----------------------------------------------------------
> 
> (Updated July 2, 2014, 6:56 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> A litle irrelevant change :)
> 
> BTW, I'm encounter this test error on Debian kfreebsd i386:
>   https://buildd.debian.org/status/fetch.php?pkg=kdeconnect&arch=kfreebsd-i386&ver=0.7-1&stamp=1404242653
> 
> Maybe someone have a clue on what is happening here :)
> 
> 
> Diffs
> -----
> 
>   tests/testsocketlinereader.cpp 797f60a 
> 
> Diff: https://git.reviewboard.kde.org/r/119091/diff/
> 
> 
> Testing
> -------
> 
> Working.
> 
> 
> Thanks,
> 
> David Suárez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140702/b2a01c7f/attachment.html>


More information about the KDEConnect mailing list