Review Request 119072: Added Triple and Double finger gestures

[Ahmed I. Khalil]

> On July 2, 2014, 12:36 a.m., Albert Vaca Cintora wrote:
> > Shouldn't we disable the menu, then?
> 
> Ahmed I. Khalil wrote:
>     IMO, we can leave it as it is, Perhaps some people will prefer the menu items and others will prefer gestures ? 
>     Also I think, we need some kind of tutorial or guide to make sure that users know about these gestures.
> 
> Albert Vaca Cintora wrote:
>     Ok, I'm fine with having both options, but the main problem is that somehow after overriding onOptionsItemSelected() to implement the menu, the "Back" button on the top bar stopped working (even though you can still go back with the system back button). Can you figure out why?
> 
> Ahmed I. Khalil wrote:
>     I've figured out why, I need to call the super implementation of onOptionsItemSelected, seems that the Action bar back button is considered as a menu item.

Do I update the current review request, or commit the change directly ?


- Ahmed


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119072/#review61440
-----------------------------------------------------------


On July 1, 2014, 6:33 p.m., Ahmed I. Khalil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119072/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 6:33 p.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Added handlers for triple and double fingers gestures, for middle click and right click, respectively. 
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadActivity.java 6cab94b 
>   src/main/java/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadGestureDetector.java PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119072/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ahmed I. Khalil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140701/ec02606c/attachment.html>