Review Request 116484: Simplify path handling

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116484/#review51366
-----------------------------------------------------------

Ship it!


Ship It!

- Albert Vaca Cintora


On Feb. 28, 2014, 6:28 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116484/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2014, 6:28 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> - prefer ::toLocalFile() to ::path(). ::path() won't work on Windows properly.
> - let KUrl handle the trailing slash adjusting, no need to do the string handling ourselves.
> - take advantage of the fact that it can be a url, at the moment it was just doing silly type conversions.
> 
> 
> Diffs
> -----
> 
>   kded/plugins/share/shareplugin.h 119658f 
>   kded/plugins/share/shareplugin.cpp 306a228 
> 
> Diff: https://git.reviewboard.kde.org/r/116484/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140228/9087f8fb/attachment.html>