Review Request 121711: Modify how the TCP socket established between kdeconnect and the device is set up for keep alive. Use IPPROTO_TCP instead of the getprotobyname method for setting keep alive characteristics and use the QTcpSockect object's own setSocketOption to activate keep alive instead of going via setsockopt.

[Pramod Dematagoda]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121711/
-----------------------------------------------------------

(Updated Dec. 30, 2014, 7:35 a.m.)


Status
------

This change has been marked as submitted.


Review request for kdeconnect and Albert Vaca Cintora.


Repository: kdeconnect-kde


Description
-------

Adjust the parameters used to set keep alive for the device's TCP socket to try and detect device disconnection faster.


lanlinkprovider: Use the const qualifier for the keep alive parameters and indent the preprocessor directives correctly. Also adjust the keep alive parameters to reflect the discussion in review 121711.


Diffs
-----

  core/backends/lan/lanlinkprovider.cpp 39d30370ce225d1979f395fc20f26b23f0e791f1 

Diff: https://git.reviewboard.kde.org/r/121711/diff/


Testing
-------

Given that a phone is connected to kdeconnect.
When the phone's wireless is switched off.
And approximately 10 seconds pass.
Then kdeconnect detects that the device has disconnected and reflects this fact.


Thanks,

Pramod Dematagoda

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20141230/7347adbb/attachment.html>