Review Request 121692: Implement a plugin for the inhibition of the screensaver when a device is connected

[Pramod Dematagoda]

> On Dec. 29, 2014, 6:16 a.m., Albert Vaca Cintora wrote:
> > Nice plugin! Some users have been requesting this for a looong time :)
> > 
> > I just tested it and works well, but I found a bug: When the screensaver has already been inhibited and then I disconnect my device, it will keep inhibited until I move the mouse/press a key and wait again for the screensaver-kick-in time. In other words, if the screensaver should appear but it does not because my device is connected, and then I leave the place (so the device is no longer connected), the screensaver won't show at all, leaving my computer unlocked! Can you somehow fix this issue? Maybe this is something worth looking at from the KScreensaver side.
> > 
> > And I was about to suggest to make it disabled by default but I see that you already did that :)
> 
> Albert Vaca Cintora wrote:
>     And just a visual thing, why not using the preferences-desktop-screensaver icon instead?

On the screen unlock, it does seem to be a KDE side problem from what I can see with my basic investigation. I have a work around for this where I use the method "SimulateUserActivity" straight after removing the inhibition, this fixes the problem for me.

And yes, I'll use that, I was looking for a better icon to represent this plugin. :)


- Pramod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121692/#review72665
-----------------------------------------------------------


On Dec. 29, 2014, 12:42 a.m., Pramod Dematagoda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121692/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2014, 12:42 a.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> This plugin serves to inhibit the screensaver when enabled for a given device and that device is connected to kdeconnect. The inhibition is lifted when the plugin is either disabled or the device disconnects from kdeconnect.
> 
> 
> Diffs
> -----
> 
>   plugins/screensaver-inhibit/screensaverinhibitplugin.cpp PRE-CREATION 
>   plugins/CMakeLists.txt de1131d 
>   plugins/screensaver-inhibit/CMakeLists.txt PRE-CREATION 
>   plugins/screensaver-inhibit/README PRE-CREATION 
>   plugins/screensaver-inhibit/kdeconnect_screensaver_inhibit.desktop PRE-CREATION 
>   plugins/screensaver-inhibit/screensaverinhibitplugin.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121692/diff/
> 
> 
> Testing
> -------
> 
> Simple testing where a phone with kdeconnect is connected to a laptop with the proposed patch and it is observed that the screensaver does not start with the phone connected and the plugin enabled. The screensaver does start with the plugin either disabled or when the phone is disconnected.
> 
> 
> Thanks,
> 
> Pramod Dematagoda
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20141229/0b4fc85d/attachment.html>