Review Request 121335: Added a CMake macro to build KDE Connect to run on systems without X

[Aleix Pol Gonzalez]

> On Dec. 3, 2014, 12:10 p.m., Aleix Pol Gonzalez wrote:
> > kded/kdeconnectd.cpp, line 83
> > <https://git.reviewboard.kde.org/r/121335/diff/1/?file=331796#file331796line83>
> >
> >     You don't need it to be unique if there's no X?
> 
> Albert Vaca Cintora wrote:
>     Will keep it this way for now, I don't know how to make unique a QCoreApp.

If you used KF5, you could use KDBusService service(KDBusService::Unique);


> On Dec. 3, 2014, 12:10 p.m., Aleix Pol Gonzalez wrote:
> > plugins/sftp/sftpplugin.cpp, line 206
> > <https://git.reviewboard.kde.org/r/121335/diff/1/?file=331800#file331800line206>
> >
> >     Maybe you want to have a class to abstract out notification emition? Looks like you're doing that in different places
> >     .
> 
> Albert Vaca Cintora wrote:
>     It will need to emit signals when the buttons are pressed and that's another layer of singals and slots to wire, so I was too lazy to do it, but I should actually implement it that way. It will make even more sense when we have a third implementation for let's say Jolla.
> 
> Aleix Pol Gonzalez wrote:
>     Check if there's any framework doing that, I vaguely remember something about that. If you can't find it, ask me.
> 
> Albert Vaca Cintora wrote:
>     I couldn't find anything (and I don't thing that something cross-platform will have support for button in notifications, because only KDE supports that). 
>     
>     Also, to implement that myself, we currently have no way to share code between all the diferent "parts" of kdeconnect (are, actually, truly independent :). Would you create a library just for that, or would you rather add a "common" directory that everybody compiles? Your advice has always been very useful in this kind of decisions =D

Patrick Von Reth, one of the KDE Windows maintainers, came up with this: https://github.com/Snorenotify/Snorenotify


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121335/#review71290
-----------------------------------------------------------


On Dec. 3, 2014, 6:47 a.m., Albert Vaca Cintora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121335/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 6:47 a.m.)
> 
> 
> Review request for kdeconnect and Aleix Pol Gonzalez.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Added a CMake macro to build KDE Connect to run on systems without X
> 
> 
> Diffs
> -----
> 
>   kded/kdeconnectd.cpp 06cec727723e64954d1ed13e5b7f12cd35a6b784 
>   CMakeLists.txt 5b916d929dfa3f3304a8ac84e7ef6c19f9aa4663 
>   core/device.cpp c4043182b8d6dd47fa1d19f8097fe1fb68489bfa 
>   plugins/sftp/sftpplugin.cpp 53b818a999d5f6c772c1a90d07a74fbd04c3870f 
>   plugins/ping/pingplugin.cpp 042a953cb3d9ba210a30630cc68a779ac170e8bf 
>   plugins/battery/batteryplugin.cpp 975ebaefad611da822468d8b73e47e3c3c3e838f 
>   plugins/share/shareplugin.cpp 2c7c8152ef97e2bc600a04ca88079224e600a428 
>   plugins/CMakeLists.txt de1131d224c453f86f79c74cb7d720cd8116e1c7 
> 
> Diff: https://git.reviewboard.kde.org/r/121335/diff/
> 
> 
> Testing
> -------
> 
> Runs fine with the macro set to YES and set to NO.
> 
> 
> Thanks,
> 
> Albert Vaca Cintora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20141204/14d5fdc6/attachment.html>