Review Request 121335: Added a CMake macro to build KDE Connect to run on systems without X

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121335/#review71290
-----------------------------------------------------------



CMakeLists.txt
<https://git.reviewboard.kde.org/r/121335/#comment49777>

    You can use the option() command.



core/device.cpp
<https://git.reviewboard.kde.org/r/121335/#comment49778>

    qWarning()?



kded/kdeconnectd.cpp
<https://git.reviewboard.kde.org/r/121335/#comment49779>

    Doing this change in the Qt5 version will make the merge easier, I wouldn't touch it in this branch.



kded/kdeconnectd.cpp
<https://git.reviewboard.kde.org/r/121335/#comment49780>

    You don't need it to be unique if there's no X?



plugins/CMakeLists.txt
<https://git.reviewboard.kde.org/r/121335/#comment49781>

    Share is not usable without GUI?
    
    I think we need it.



plugins/sftp/sftpplugin.cpp
<https://git.reviewboard.kde.org/r/121335/#comment49782>

    Maybe you want to have a class to abstract out notification emition? Looks like you're doing that in different places
    .



plugins/share/shareplugin.cpp
<https://git.reviewboard.kde.org/r/121335/#comment49783>

    ?


- Aleix Pol Gonzalez


On Dec. 3, 2014, 6:47 a.m., Albert Vaca Cintora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121335/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 6:47 a.m.)
> 
> 
> Review request for kdeconnect and Aleix Pol Gonzalez.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Added a CMake macro to build KDE Connect to run on systems without X
> 
> 
> Diffs
> -----
> 
>   kded/kdeconnectd.cpp 06cec727723e64954d1ed13e5b7f12cd35a6b784 
>   CMakeLists.txt 5b916d929dfa3f3304a8ac84e7ef6c19f9aa4663 
>   core/device.cpp c4043182b8d6dd47fa1d19f8097fe1fb68489bfa 
>   plugins/sftp/sftpplugin.cpp 53b818a999d5f6c772c1a90d07a74fbd04c3870f 
>   plugins/ping/pingplugin.cpp 042a953cb3d9ba210a30630cc68a779ac170e8bf 
>   plugins/battery/batteryplugin.cpp 975ebaefad611da822468d8b73e47e3c3c3e838f 
>   plugins/share/shareplugin.cpp 2c7c8152ef97e2bc600a04ca88079224e600a428 
>   plugins/CMakeLists.txt de1131d224c453f86f79c74cb7d720cd8116e1c7 
> 
> Diff: https://git.reviewboard.kde.org/r/121335/diff/
> 
> 
> Testing
> -------
> 
> Runs fine with the macro set to YES and set to NO.
> 
> 
> Thanks,
> 
> Albert Vaca Cintora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20141203/63649d8b/attachment.html>