Review Request 119937: Streamline internal naming (kdeconnect ? org.kde.kdeconnect)

Aleix Pol Gonzalez aleixpol at kde.org
Mon Aug 25 23:46:11 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119937/#review65256
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Aug. 25, 2014, 11:42 p.m., Elias Probst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119937/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2014, 11:42 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> - correct PluginName in metadata
> - correct plasmoid installation directory
> - correct appName in aboutData
> - remove trailing whitespace.
> 
> 
> Diffs
> -----
> 
>   kded/kdeconnectd.cpp 2b4589d479ff676ab24273b38c2260b9842fd441 
>   plasmoid/CMakeLists.txt 3289115e43efde562a7ae169852df8d5f02e71a8 
>   plasmoid/declarativeplugin/CMakeLists.txt b9e827cc62674c61d42d2dcc14b3815cf4a46e1c 
>   plasmoid/package/metadata.desktop 473a2ef1fd950a46d91ed91ce8b653aa6534763f 
> 
> Diff: https://git.reviewboard.kde.org/r/119937/diff/
> 
> 
> Testing
> -------
> 
> Works as expected.
> Shows up as org.kde.kdeconnect instead of kdeconnect in plasma's config files (just as the other plasmoids).
> 
> 
> Thanks,
> 
> Elias Probst
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140825/1dc7f1a3/attachment.html>


More information about the KDEConnect mailing list