Review Request 119692: Properly restore the selected player after a plugin reconnect.

Albert Vaca Cintora albertvaka at gmail.com
Wed Aug 13 15:50:21 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119692/#review64484
-----------------------------------------------------------

Ship it!


Looks good! Do you have a developer account to push it to the repo? If not I can do it in your name.

- Albert Vaca Cintora


On Aug. 10, 2014, 2:21 p.m., Job Noorman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119692/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2014, 2:21 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Properly restore the selected MPRIS player after a plugin reconnect.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/kde/kdeconnect/Plugins/MprisPlugin/MprisPlugin.java 4ad57beaa773722c56e9f1245a3712c8ea25b479 
>   src/main/java/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java fe5989ccd9fe2b33e31ba6c4badfb8b6f30257fe 
> 
> Diff: https://git.reviewboard.kde.org/r/119692/diff/
> 
> 
> Testing
> -------
> 
> Whenever the link with a device goes down (the easiest way to test this is to lock the phone's screen), the connection with the MPRIS plugin is re-established when the link goes up again. This patch makes sure that the currently selected player (the one stored on the MprisPlugin instance) is also selected in the MprisActivity. Currently, the first player in the list is always selected.
> 
> 
> Thanks,
> 
> Job Noorman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140813/be2003ad/attachment.html>


More information about the KDEConnect mailing list