Review Request 119254: Add support for receiving keyboard entries

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119254/#review63618
-----------------------------------------------------------


Looks good, but it would be really cool if we don't need to implement support for each special key (dot, comma....). What I would do is that when you press a key on android that has a text representation, just send that text to kde and enter it directly (not simulating keycodes, but just inserting the text) and only use keycodes for the keys that don't have text representation (Esc, Shift...). This way we will support every key without having to add special support for them, and even keyboards for "exotic" languages. 

Also I found a couple of small (and easy to fix) bugs that would be nice to fix before merging it: On Android, the back key doesn't work anymore in the input window (because you are capturing it as a key) and also the keyboard is not shown if you are in landscape mode.

Thanks!

- Albert Vaca Cintora


On ago. 1, 2014, 5:32 a.m., Saikrishna Arcot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119254/
> -----------------------------------------------------------
> 
> (Updated ago. 1, 2014, 5:32 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Add support for receiving keyboard entries.
> 
> This patch gets the keyboard entries from the Android client and passes along the keycode.
> 
> The Android version is [here](https://git.reviewboard.kde.org/r/119255/).
> 
> 
> Diffs
> -----
> 
>   plugins/mousepad/mousepadplugin.h 64f5d880057820127788d7653796946bffcedafe 
>   plugins/mousepad/mousepadplugin.cpp 64aae5cc938e2630bde3f329ec01bcd9b8651ce5 
> 
> Diff: https://git.reviewboard.kde.org/r/119254/diff/
> 
> 
> Testing
> -------
> 
> Checked and tested. Only lowercase letters, numbers, and the period and comma work. 
> 
> 
> Thanks,
> 
> Saikrishna Arcot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140801/7d4d03da/attachment.html>