Review Request 117387: Fix socketlinereader test

David Suárez david.sephirot at gmail.com
Sat Apr 12 21:40:25 UTC 2014



> On April 12, 2014, 1:29 p.m., Albert Vaca Cintora wrote:
> > Hello David, do you have a developer account in KDE to apply this patch? If not, I can push the changes in your name.
> 
> David Suárez wrote:
>     Just filled the Developer Application, waiting for aproval.
> 
> Albert Vaca Cintora wrote:
>     To speed up things I will just push it myself, because it's a bad thing to have the test broken.
>     
>     Also note that before you get a developer account you should have a few contributions approved, so maybe your request is denied by now.

Not problem, thanks !


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117387/#review55508
-----------------------------------------------------------


On April 12, 2014, 9:20 p.m., David Suárez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117387/
> -----------------------------------------------------------
> 
> (Updated April 12, 2014, 9:20 p.m.)
> 
> 
> Review request for kdeconnect and Àlex Fiestas.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Remove the empty line before compare the packages received because we do not treat "\n" as a package.
> 
> 
> Diffs
> -----
> 
>   kded/autotests/testsocketlinereader.cpp 5762504 
> 
> Diff: https://git.reviewboard.kde.org/r/117387/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Suárez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140412/8cf70b12/attachment-0001.html>


More information about the KDEConnect mailing list