I want to learn to patch

[James Richard Tyrer]

First I admire your enthusiasm.  Do not take offense at my rather direct 
engineer's analysis.

Dotan Cohen wrote:
> Here is a very simple bug, that I want to learn to submit patches with:
> https://bugs.kde.org/show_bug.cgi?id=188383
> 
I have to warn your that there have been major arguments about this 
issue and I have rather strong opinions about it.  We won't worry about 
my opinions but expect to run into some resistance.

> I have googled KDE Development and found lots of tutorials from KDE 2
> and KDE 3, and lots of tutorials about setting up what seems to be a
> very complex and error-prone development environment. However, as one
> can simply view the code online [1] I would like to work this way. I
> looked around the websvn tree for the file(s) that contain the string
> "Other Tabs" from the bug in question, but I could not find them. So I
> have these two questions:
> 
> 1) How does one go about finding the correct file(s) to modify?

This is probably part of the Konqueror code:

	KDEBase:Apps:Konqueror

in SVN.  You can find the relevant files using "Find File" looking for 
"*.*c*" with a string in: "Context::Containing Text" or use Grep 
(command line) in  Konsole.

> 2) How does one make a diff file?

First, you need to checkout and build the KDEBase module from SVN:

svn co svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase

Well actually, you need to install subversion, the GNU C/C++ compiler, 
and CMake.  I would suggest reading the relevant (user/client) parts of:

	http://svnbook.red-bean.com/

Now, having found what needs to be changed:

1.  Change it.
2.  Compile and install.
3.  Test to see that it works like you want (if not go back to #1)
4.  Execute: "svn status" to see that all is well
5.  Execute: "svn up" to see that there is no conflict
6.  Execute: "svn diff" to see your patch.
7.  If you want a patch file, Execute: "svn diff > file.diff
8.  Post your patch to the "kde-devel" (subscribe to it) mailing list
     with the Subject starting with "[PATCH]" or attach the diff file to
     the bug and label the attachment as a Patch.

So, that is a basic outline.  I expect that you might have further 
questions.

-- 
JRT

Linux (mostly) From Scratch

___________________________________________________
This message is from the kde mailing list.
Account management:  https://mail.kde.org/mailman/listinfo/kde.
Archives: http://lists.kde.org/.
More info: http://www.kde.org/faq.html.